Skip to content

Conversation

@laithmassoud
Copy link

@thet
Copy link
Member

thet commented Jul 11, 2023

Hi, sorry for the late reply.

Is this fix still relevant for you?

You're patching a generated build. When updating widgets.js from Mockup (Mockup version 2.x) this patch would be overwritten again.

So a better fix would be to create a patch with diff which can be applied with patch. The fix could go into plone.app.widgets 1.x or to Mockup 2.x.

Note that both versions are quite old and already unmaintained. But I'd merge a PR with a fix as described above.
This PR isn't sustainable and would be overwritten if someone builds a new bundle from Mockup, so this should better live in your branch, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants