fix: update attention matrix label color scale value from -1.0 to 0.0#49
Closed
Gabriellavoura wants to merge 1 commit intopoloclub:mainfrom
Closed
fix: update attention matrix label color scale value from -1.0 to 0.0#49Gabriellavoura wants to merge 1 commit intopoloclub:mainfrom
Gabriellavoura wants to merge 1 commit intopoloclub:mainfrom
Conversation
Collaborator
|
Thank you! This issue was resolved during the development of the new features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct softmax range in attention matrix visualization
Hi there! First of all, thanks for this awesome project.
As reported in issue #31, there’s a small mistake in the attention matrix softmax range.
This PR fixes the label of the attention matrix and updates the article image to reflect the corrected range.
Changes
AttentionMatrix.sveltefrom -1.0 to 0.0, ensuring it reflects the valid range of softmax scores (PS
I accidentally closed the previous PR when I deleted the fork from my GitHub. 😅