mapping-tester fixes for errors caused by conservative mappings#250
Merged
davidscn merged 1 commit intoOct 22, 2025
Merged
Conversation
Member
|
@FabioTucciarone can you rebase and trigger the CI again? |
- incorrect configuration causing crash - incorrect reading of timing data causing null entries
cfb8224 to
1a1d80e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR aims to fix some small problems in the mapping-tester concerning conservative mappings.
Description of the errors fixed by this PR
Executing a conservative mapping using the current
config-template.xmlcauses the following error:This is caused by a small error in the configuration of the coupling scheme.
Using the
gatherstats.pyscript with a fix for the previous problem applied as follows:causes the entries for
mapDataTimeandcomputeMappingTimeto be empty:Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md../changelog-entries/(create if necessary).precice/tutorials/aste-turbine.