Mapping remaining pokemon_found_out to dungeon name and floor numbers#476
Merged
AnonymousRandomPerson merged 4 commits intopret:masterfrom Apr 20, 2026
Merged
Mapping remaining pokemon_found_out to dungeon name and floor numbers#476AnonymousRandomPerson merged 4 commits intopret:masterfrom
AnonymousRandomPerson merged 4 commits intopret:masterfrom
Conversation
SethBarberee
approved these changes
Apr 20, 2026
AnonymousRandomPerson
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the following list of dungeon names, mapped from the DungeonID enum:
Mapped the Pokémon found_out id by using the PMDe tool, where I generated the following map:
dungeon_mons_mapper.json
Then run a small script to replace all occurrences like
sed -i 's/pokemon_found_out112/StormySea_1F_5F_Pokemon/g' ${files_to_replace[i]}Only manual change I had to make was Autopilot which shares some of the ids with D51, as we don't have the Autopilotpokemon_found.json.Only inconsistency with the dungeon name is on D51, where some of the floors uses the Autopilot reference