Fix softlock on modern when selecting "Team" from menu#478
Merged
AnonymousRandomPerson merged 1 commit intopret:masterfrom Apr 29, 2026
Merged
Conversation
SethBarberee
approved these changes
Apr 29, 2026
AnonymousRandomPerson
approved these changes
Apr 29, 2026
Collaborator
AnonymousRandomPerson
left a comment
There was a problem hiding this comment.
Very interesting, thanks for investigating!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With modern compiler, the
sFriendListvariable is placed directly aftergUnknown_3000E94in memory.sub_80089AC(), which appears to draw the background for windows, does incorrect bounds checking, which can cause it to overflow thegUnknown_3000E94array. This is problematic for the end of dungeon window, which scrolls up from the bottom of the screen, guaranteeing an overflow. After the overflow,sFriendListis overwritten and upon trying to open the "Team" menu, the game softlocks.Softlock repro steps: