Decompile revision 0xA changes for wireless_communication_status without fakematch#744
Open
LumioseSil wants to merge 5 commits into
Open
Decompile revision 0xA changes for wireless_communication_status without fakematch#744LumioseSil wants to merge 5 commits into
LumioseSil wants to merge 5 commits into
Conversation
LumioseSil
force-pushed
the
fixthematch
branch
2 times, most recently
from
f461b71 to
976776a
Compare
…tatus So one of the emerald UBFixes mentions that 0xFF can happen, and mentions that GROUPTYPE_NONE is 0xFF, and shouldn't be used as an index into groupCounts. It mentions that int theory the only activity with this group type (ACTIVITY_SEARCH) wouldn't satisfy the condition below, but not necessarily. Well, revision A of FRLG fixes this but has an even broader check, by skipping ALL invalid values by adding a range check. For this reason, I have also opted to do || UBFIX.
LumioseSil
changed the title
LumioseSil
changed the title
Contributor
Author
|
Ping? |
Contributor
Author
|
Ping. |
Contributor
Author
|
Whole 0xA version should be UBFix because none of this seems emulation related and Nintendo wouldn't change a line of code without a reason. |
Contributor
Author
|
Also said change fixes a UB reported in emerald for this same function in Union room. |
Contributor
Author
|
Ping. Basically this is the most important PR. |
Contributor
Author
|
Out of all the others I submitted I mean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So one of the emerald UBFixes mentions that 0xFF can happen, and mentions that GROUPTYPE_NONE is 0xFF, and shouldn't be used as an index into groupCounts. It mentions that int theory the only activity with this group type (ACTIVITY_SEARCH) wouldn't satisfy the condition below, but not necessarily.
Well, revision A of FRLG fixes this but has an even broader check, by skipping ALL invalid values by adding a range check. For this reason, I have also opted to do || UBFIX.