Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1543
There are 4 types of polymeric nodes.
variantthat could be different keywords. These usually are parsed as astring.variantthat could be a name given by a developer or a keyword. These are parsed as aTerminalNode.variantthat could be anExpressionor aStatement. These are parsed as aNonterminalNode.variantthat could be anything. This is more general and has logic for cases 2 and 3.all of this logic put in 4 different base classes cleans up everything.
I added 4 cases just to be very specific but I'd be willing to merge case 2 and 3 into case 4.