Drop opentelemetry-instrumentation-dnspython — no upstream package exists#61
Conversation
PR #60 listed it among the auto-instrumentation packages by analogy with the others, but there's no upstream OTel auto-instrumentation for dnspython on PyPI. The build fails with: ERROR: Could not find a version that satisfies the requirement opentelemetry-instrumentation-dnspython<1,>=0.48b0 (from versions: none) ERROR: No matching distribution found for opentelemetry-instrumentation-dnspython<1,>=0.48b0 DNS lookups during SPF/DKIM/DMARC checks won't have per-call spans, but the manual milter.process_email parent still wraps them — trace context is preserved, only the per-DNS-call breakdown is lost. Comment on the Dockerfile updated to call this out explicitly so the next person who looks at the list knows why it's three packages, not four.
Greptile SummaryRemoves Confidence Score: 5/5Safe to merge — removes a build-breaking non-existent package with no functional regressions. The change is a one-line pip install removal of a package that provably doesn't exist on PyPI, which was causing immediate Docker build failures. The comment block is updated accurately. The three remaining instrumentation packages are real and unaffected. No logic, security, or data concerns. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["docker build --build-arg INSTALL_OTEL=true"] --> B{INSTALL_OTEL == true?}
B -- No --> C[Skip OTel install]
B -- Yes --> D["pip install opentelemetry-api/sdk/exporter-otlp-proto-http\nopentelemetry-distro\nopentelemetry-instrumentation-urllib3\nopentelemetry-instrumentation-botocore\nopentelemetry-instrumentation-logging"]
D --> E["opentelemetry-instrument entrypoint.sh (runtime)"]
E --> F["Auto spans: urllib3 / botocore / logging"]
E --> G["Manual span: milter.process_email (wraps DNS calls)"]
G --> H["DNS lookups (SPF/DKIM/DMARC) — no per-call spans"]
Reviews (1): Last reviewed commit: "Drop opentelemetry-instrumentation-dnspy..." | Re-trigger Greptile |
Summary
PR #60 listed
opentelemetry-instrumentation-dnspythonamong the auto-instrumentation packages by analogy with the others, but there's no upstream OTel auto-instrumentation for dnspython on PyPI. The Docker build fails immediately:The other three (
urllib3,botocore,logging) are fine and remain. DNS lookups during SPF/DKIM/DMARC checks won't get their own spans, but the manualmilter.process_emailparent span still wraps them — we lose per-DNS-call breakdown, not trace context.Test plan
INSTALL_OTEL=truesucceeds.