Skip to content

feat(process_exporter): add support for recheck-with-time-limit #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(process_exporter): add support for recheck-with-time-limit #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions roles/process_exporter/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ process_exporter_names: |
- '.+'
{% endraw %}

process_exporter_recheck_time_limit: "0"

process_exporter_binary_install_dir: "/usr/local/bin"
process_exporter_system_group: "process-exp"
process_exporter_system_user: "{{ process_exporter_system_group }}"
Expand Down
7 changes: 7 additions & 0 deletions roles/process_exporter/meta/argument_specs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ argument_specs:
- "Syntax is the same as in"
- "L(using-a-config-file Default is consistent with deb/rpm packages,https://github.com/ncabatoff/process-exporter#using-a-config-file Default is consistent with deb/rpm packages)"
default: !unsafe "[{name: '{{.Comm}}', cmdline: [.+]}]"
process_exporter_recheck_time_limit:
description:
- "Enable process rechecking: process names are re-evaluated only this much time after their start, but no longer."
- "See L(the time.ParseDuration documentation,https://pkg.go.dev/time#ParseDuration) for the supported duration formats."
- "This setting can be useful to make sure processes are grouped correctly if their name changes shortly after they start."
- "The default value leaves this feature disabled."
default: "0"
process_exporter_binary_install_dir:
description:
- "I(Advanced)"
Expand Down
1 change: 1 addition & 0 deletions roles/process_exporter/molecule/alternative/molecule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,6 @@ provisioner:
cmdline:
- crond
{% endraw %}
process_exporter_recheck_time_limit: 180s
process_exporter_binary_url: "https://github.com/ncabatoff/process-exporter/releases/download/v{{\
\ process_exporter_version }}/process-exporter-{{ process_exporter_version }}.linux-amd64.tar.gz"
3 changes: 3 additions & 0 deletions roles/process_exporter/templates/process_exporter.service.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ ExecStart={{ process_exporter_binary_install_dir }}/process-exporter \
{% endif -%}
{% if process_exporter_tls_server_config | length > 0 or process_exporter_http_server_config | length > 0 or process_exporter_basic_auth_users | length > 0 %}
'--web.config.file={{ process_exporter_config_dir }}/web_config.yml' \
{% endif %}
{% if process_exporter_recheck_time_limit != "0" %}
'--recheck-with-time-limit={{ process_exporter_recheck_time_limit }}' \
{% endif %}
'--web.listen-address={{ process_exporter_web_listen_address }}' \
'--web.telemetry-path={{ process_exporter_web_telemetry_path }}'
Expand Down