fix(ipmi_exporter): Fix privilege escalation when running in local mode #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaloyan Kotlarski <[email protected]>
|
Would love to see this merged |
Add the selinus tag to all SELinux tasks to allow skipping/selecting them
gardar
requested changes
Aug 12, 2025
| - "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}" | ||
| - configure | ||
| - "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}_configure" | ||
| - selinux |
Member
There was a problem hiding this comment.
Why are you adding this tag? It seems unrelated to the subject
Comment on lines
+34
to
+43
| - name: Create sudoers file to allow passwordless IPMI commands | ||
| ansible.builtin.copy: | ||
| dest: "/etc/sudoers.d/{{ ipmi_exporter_system_user }}" | ||
| content: | | ||
| {{ ipmi_exporter_system_user }} ALL=(ALL) NOPASSWD: {{ ipmi_exporter_sudo_commands | join(', ') }} | ||
| owner: root | ||
| group: root | ||
| mode: '0440' | ||
| become: true | ||
| when: ipmi_exporter_system_user is defined |
Comment on lines
+16
to
+23
| ipmi_exporter_sudo_commands: | ||
| - /usr/sbin/ipmimonitoring | ||
| - /usr/sbin/ipmi-sensors | ||
| - /usr/sbin/ipmi-dcmi | ||
| - /usr/sbin/ipmi-raw | ||
| - /usr/sbin/bmc-info | ||
| - /usr/sbin/ipmi-chassis | ||
| - /usr/sbin/ipmi-sel |
Member
There was a problem hiding this comment.
Does the user ever need to overwrite this? Perhaps it would be better to place this as a internal variable under vars/main.yml
Member
|
The sudo policy should not be used for every installation of ipmi_exporter since it only applies to the local mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526