enhancement - Update handlers to allow skipping snmp_exporter handlers #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible_skip_tags Signed-off-by: sauce-nhendrickson <[email protected]>
sauce-nhendrickson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an issue often when standing up new hosts running snmp_exporters that our dry-run process against that new node fails due to the handlers attempting to run and failing since snmp_exporter hasn't yet installed it's systemd service.
This change allows us to skip running those handlers when the
ansible_skip_tagsmagic variable contains the new tagsnmp_exporter_restartthis would be passed on the command line via--skip-tagsper usual and allow us to skip solely that tag during our dry-run stages.