Replaces deprecated Android addDefaultShareMenuItem with setShareState#307
Open
jezallan wants to merge 1 commit intoproyecto26:developfrom
Open
Replaces deprecated Android addDefaultShareMenuItem with setShareState#307jezallan wants to merge 1 commit intoproyecto26:developfrom
jezallan wants to merge 1 commit intoproyecto26:developfrom
Conversation
Member
|
@jezallan Hey mate, thanks for your contribution! Can you use Reflection to avoid a BREAKING CHANGE here? Please check out this example: https://github.com/proyecto26/react-native-inappbrowser/blob/develop/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java#L95 Let me know what you think! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The Android option
enableDefaultShareuses a deprecated method setDefaultShareMenuItemEnabled on CustomTabsIntent.It is not possible to disable the share button with the current option.
What is the new behavior?
This PR replaces the
enableDefaultShareoption with a newenableShareStateoption that uses the new setShareState method.This allows the share button in the toolbar to be enabled or disabled.
BREAKING CHANGES:
enableDefaultShareoption changed toenableShareState