feat(android): implement incognito mode#455
Draft
renanmav wants to merge 8 commits intoproyecto26:developfrom
Draft
feat(android): implement incognito mode#455renanmav wants to merge 8 commits intoproyecto26:developfrom
renanmav wants to merge 8 commits intoproyecto26:developfrom
Conversation
jdnichollsc
reviewed
Jul 29, 2024
|
|
||
| useEffect(() => { | ||
| InAppBrowser.mayLaunchUrl('https://reactnative.dev', []); | ||
| InAppBrowser.mayLaunchUrl('https://login.coinbase.com', []); |
Member
There was a problem hiding this comment.
@renanmav hey bro, can you use react native website instead please?
| incognito: true, | ||
| }; | ||
| console.log('openLink -> options', options); | ||
| const result = await InAppBrowser.openAuth(url, url, options); |
Member
There was a problem hiding this comment.
This utility function is just an example for opening a external link? Please use another function for that openAuth example! 🙏
| "@react-native-community/eslint-config": "^3.0.3", | ||
| "eslint": "^8.20.0", | ||
| "flow-bin": "^0.183.1", | ||
| "flow-bin": "^0.135.0", |
Member
There was a problem hiding this comment.
Maybe we can remove flow now because TypeScript is used by default now 🤔
| AuthSessionResult, | ||
| InAppBrowserOptions, | ||
| } from './types'; | ||
| import type { EventSubscription } from 'react-native/Libraries/vendor/emitter/EventEmitter'; |
Member
There was a problem hiding this comment.
So it's not going to work with old versions of RN 🤔
| !_redirectHandler, | ||
| 'InAppBrowser.openAuth is in a bad state. _redirectHandler is defined when it should not be.' | ||
| ); | ||
| console.log('openAuthSessionPolyfillAsync', options); |
Member
There was a problem hiding this comment.
Please remove logs from source code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].