[Android] fixed share icon display issue on android

[hrishiakhade]

PR Checklist

• The PR title follows our guidelines: https://github.com/proyecto26/react-native-inappbrowser/blob/main/CONTRIBUTING.md#pull-request-process.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• All existing tests are passing
• Tests for the changes are included

What is the current behavior?

enableDefaultShare: false is not working on android

What is the new behavior?

enableDefaultShare: false is now working on android

Fixes/Implements/Closes #[Issue Number].

Replaced the native library code in RNInAppBrowser.java

from

   if (options.hasKey(KEY_DEFAULT_SHARE_MENU_ITEM) && 
       options.getBoolean(KEY_DEFAULT_SHARE_MENU_ITEM)) {
     builder.addDefaultShareMenuItem();
   }
   ```

to
if(options.hasKey(KEY_DEFAULT_SHARE_MENU_ITEM)){
 if(options.getBoolean(KEY_DEFAULT_SHARE_MENU_ITEM)){
   builder.setShareState(CustomTabsIntent.SHARE_STATE_ON);
 }else{
   builder.setShareState(CustomTabsIntent.SHARE_STATE_OFF);
 }
}else{
 builder.setShareState(CustomTabsIntent.SHARE_STATE_OFF);
}

[twocs]

@hrishiakhade marked the conversation https://github.com/proyecto26/react-native-inappbrowser/pull/462/files/1b3b1c3dd94fc5f793bb3fb87dabd4634836a3ef#r1695653707 as resolved because the indentation has been fixed, and asked "Pls check" but the merge was not been subsequently reviewed. It looks like the requested change has been implemented completely. @jdnichollsc can approve and merge it in?

[jdnichollsc]

@hrishiakhade I think we can remove this else condition, so users can specify this option to enable/disable that share state instead, what do you think?

[jdnichollsc]

@twocs oh I added a small comment here, sorry for the delay folks!
Next time, please send me a message from WhatsApp or Telegram, this is my profile: https://bio.link/jdnichollsc 🙏

[RomualdPercereau]

Ok for merging? @jdnichollsc