Skip to content

Allow multipart uploads when Content-Type has been set on on a Session #7084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Open

Allow multipart uploads when Content-Type has been set on on a Session #7084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c44fb8
Handle Content-Type being explicitly unset on a multipart file upload
gvengel Nov 11, 2025
104446d
Add test to verify multipart session content type override
gvengel Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/requests/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,8 @@ def prepare_body(self, data, files, json=None):

self.prepare_content_length(body)

# Add content-type if it wasn't explicitly provided.
if content_type and ("content-type" not in self.headers):
# Add content-type if it wasn't explicitly provided, or it was explicitly unset
if content_type and self.headers.get("content-type") is None:
self.headers["Content-Type"] = content_type

self.body = body
Expand Down
12 changes: 12 additions & 0 deletions tests/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,6 +1852,18 @@ def test_can_send_objects_with_files(self, httpbin, files):
p = r.prepare()
assert "multipart/form-data" in p.headers["Content-Type"]

def test_can_override_session_content_type_with_multipart_request(self, httpbin):
s = requests.Session()
s.headers["Content-Type"] = "application/json"
data = {"a": "this is a string"}
files = {"b": "foo"}
headers = {"Content-Type": None}
r = requests.Request(
"POST", httpbin("post"), headers=headers, data=data, files=files
)
p = s.prepare_request(r)
assert "multipart/form-data" in p.headers["Content-Type"]

def test_can_send_file_object_with_non_string_filename(self, httpbin):
f = io.BytesIO()
f.name = 2
Expand Down