Conversation
Create track info in method not in constructor
MediaInfo -> MediaProps
Fluenttools
--- updated-dependencies: - dependency-name: FluentAssertions dependency-version: 8.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…/develop/FluentAssertions-8.3.0 Update FluentAssertions to 8.3.0
Bumps Microsoft.NET.Test.Sdk from 17.14.0 to 17.14.1 --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 17.14.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…/develop/nuget-deps-0caa32f856 Bump the nuget-deps group with 1 update
Bumps System.CommandLine from 2.0.0-beta4.22272.1 to 2.0.0-beta5.25306.1 Bumps System.CommandLine.NamingConventionBinder from 2.0.0-beta4.22272.1 to 2.0.0-beta5.25306.1 --- updated-dependencies: - dependency-name: System.CommandLine dependency-version: 2.0.0-beta5.25306.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: System.CommandLine.NamingConventionBinder dependency-version: 2.0.0-beta5.25306.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…lop/nuget-deps-92a4894680 Bump the nuget-deps group with 2 updates
There was a problem hiding this comment.
Pull request overview
This pull request upgrades PlexCleaner from .NET 9 to .NET 10 with Native AOT support and comprehensive nullable types implementation.
Changes:
- Updated from .NET 9 to .NET 10 across all projects
- Added nullable types and Native AOT support with JSON source generators
- Changed MediaInfo from XML to JSON output for AOT compatibility (SidecarFile v5)
Reviewed changes
Copilot reviewed 91 out of 95 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Version bumped to 3.15 |
| PlexCleaner/Extensions.cs | Critical Issue: Invalid extension method syntax |
| PlexCleaner/ConfigFileJsonSchema.cs | Changed to static Schema property affecting serialization |
| PlexCleaner/*.csproj | Updated to .NET 10, enabled nullable and PublishAot |
| PlexCleaner/*JsonSchema.cs | Added JSON source generation contexts for AOT |
| PlexCleaner/MediaInfo*.cs | Changed from XML to JSON, added custom XML parser |
| Docker/* | Removed Alpine and Debian builds, kept Ubuntu Rolling only |
| Tests/* | Added SamplesFixture for mutable test scenarios |
| Docs/* | Added new documentation for language matching, custom options, closed captions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 94 out of 98 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 97 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntu:rollingimages are published (Alpine and Debian discontinued).linux/amd64andlinux/arm64architectures supported (linux/arm/v7discontinued).