Merged
Conversation
added 3 commits
December 5, 2024 15:48
seba-aln
force-pushed
the
feat/replace-transport-with-httpx
branch
from
e4f6490 to
636acaf
Compare
seba-aln
force-pushed
the
feat/replace-transport-with-httpx
branch
from
4c38e13 to
05c8e5b
Compare
seba-aln
requested review from
jguz-pubnub,
kazydek,
techwritermat and
wkal-pubnub
as code owners
jguz-pubnub
reviewed
Dec 18, 2024
|
|
||
| def close(self): | ||
| self.is_closed = True | ||
| super().aclose() |
Contributor
There was a problem hiding this comment.
Why it's called aclose()?
Author
There was a problem hiding this comment.
in code we call close() method but async httpx uses aclose() with a standing as an "asynchronous". that's why I have to cover this base
seba-aln
force-pushed
the
feat/replace-transport-with-httpx
branch
2 times, most recently
from
3b62802 to
18865c8
Compare
seba-aln
force-pushed
the
feat/replace-transport-with-httpx
branch
from
18865c8 to
f2d76aa
Compare
seba-aln
force-pushed
the
feat/replace-transport-with-httpx
branch
from
7d4dd59 to
63e3cf1
Compare
jguz-pubnub
approved these changes
Jan 9, 2025
Co-authored-by: Mateusz Wiktor <39187473+techwritermat@users.noreply.github.com>
Co-authored-by: Mateusz Wiktor <39187473+techwritermat@users.noreply.github.com>
Author
|
@pubnub-release-bot release as 10.0.0 |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Introduced configurable request handler with HTTP/2 support