Chat improvements: read receipts, ractions, presence, and conversation memberships#23
Open
jakub-grzesiowski wants to merge 6 commits intomasterfrom
Open
Chat improvements: read receipts, ractions, presence, and conversation memberships#23jakub-grzesiowski wants to merge 6 commits intomasterfrom
jakub-grzesiowski wants to merge 6 commits intomasterfrom
Conversation
marcin-cebo
approved these changes
Jan 19, 2026
| Message readMessage = null; | ||
| someChannel.OnMessageReceived += message => | ||
| { | ||
| if (message.MessageText == "READ MEEEE") |
There was a problem hiding this comment.
What about extracting "READ MEEEE" to variable and reused below in line
await someChannel.SendText("READ MEEEE");
| /// <returns>A ChatOperationResult containing the created channel wrapper with channel and membership information.</returns> | ||
| public async Task<ChatOperationResult<CreatedChannelWrapper>> CreateGroupConversation(List<User> users, string channelId = "", | ||
| ChatChannelData? channelData = null, ChatMembershipData? membershipData = null) | ||
| ChatChannelData? channelData = null, ChatMembershipData? hostMembershipData = null, ChatMembershipData? inviteeMembershipData = null) |
There was a problem hiding this comment.
Is this desired for
ChatMembershipData? inviteeMembershipData = null
to be singular not plural?
| { | ||
| return result; | ||
| } | ||
| if (getMembers.Result.Memberships?[0] != null) |
There was a problem hiding this comment.
Shouldn't be:
if (getMembers.Result.Memberships != null && getMembers.Result.Memberships.Count > 0)
| { | ||
| return result; | ||
| } | ||
| if (getMembers.Result.Memberships?[0] != null) |
There was a problem hiding this comment.
Shouldn't be:
if (getMembers.Result.Memberships != null && getMembers.Result.Memberships.Count > 0)
?
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.