Upgrade to Blacklight 9#5235
Merged
sandbergja merged 17 commits intomainfrom Mar 24, 2026
Merged
Conversation
sandbergja
force-pushed
the
blacklight9
branch
from
91453f2 to
fc11457
Compare
This was referenced Nov 4, 2025
sandbergja
force-pushed
the
blacklight9
branch
from
fc11457 to
4879d16
Compare
sandbergja
force-pushed
the
blacklight9
branch
3 times, most recently
from
8174d15 to
5f00837
Compare
sandbergja
force-pushed
the
blacklight9
branch
from
5f00837 to
c8bfd9e
Compare
sandbergja
force-pushed
the
blacklight9
branch
2 times, most recently
from
4e31fb6 to
67f3942
Compare
Currently, several tests are failing because JS hits an error before loading all the necessary things (we need the fix to projectblacklight/blacklight#3724 to be released)
…'s new API Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: James R. Griffin III <jrgriffiniii@users.noreply.github.com> Co-authored-by: Ryan Laddusaw <rladdusaw@users.noreply.github.com>
This matches the API change in projectblacklight/blacklight#3743
It was removed upstream in projectblacklight/blacklight#3751, and we agree with this removal.
christinach
approved these changes
Mar 24, 2026
Member
christinach
left a comment
christinach
left a comment
There was a problem hiding this comment.
@sandbergja 🍄 thank you for all of your work on this upgrade! !!!
| def remove_deftype(solr_parameters) | ||
| # Inlcuding a defType=lucene, as stock blacklight does, can cause our facet-only | ||
| # advanced search results to be empty | ||
| solr_parameters.delete('defType') |
| describe 'defType' do | ||
| let(:blacklight_config) { CatalogController.blacklight_config } | ||
| it 'does not add a defType' do | ||
| # Stock blacklight adds defType=lucene, which causes empty results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly updates to accommodate changes to the API of Blacklight's MetadataFieldComponent.