fix: use memory index for cabi_realloc$N export suffix#63
Merged
Conversation
The merger exported cabi_realloc$N using the component index as suffix, but the P2 wrapper looks them up by memory index. When component indices are non-consecutive after flattening (e.g., 0, 3, 5), the naming mismatch caused all components to fall back to component 0's allocator, leading to cross-memory heap corruption. Fix: use merged.memory_index_map to get the memory index for the component's first memory, and use that as the export suffix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The merger exported
cabi_realloc$Nusing component index as suffix, but the P2wrapper looks them up by memory index. When component indices are non-consecutive
after flattening (e.g., 0, 3, 5), the naming mismatch caused all components to
fall back to component 0's allocator — cross-memory heap corruption.
Fix: use
memory_index_mapto get the merged memory index and use that as suffix.Test plan
🤖 Generated with Claude Code