Skip to content

fix: use resource_definer for graph override instead of is_reexporter #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
Mar 22, 2026
Merged

fix: use resource_definer for graph override instead of is_reexporter #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions meld-core/src/resolver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,8 +2113,12 @@ impl Resolver {
.unwrap_or(&op.import_field);
if rg.defines_resource(*to_comp, iface, rn) {
op.callee_defines_resource = true;
} else if rg.is_reexporter(*to_comp, iface, rn)
} else if rg
.resource_definer(iface, rn)
.is_some()
{
// Graph knows about this resource and says
// this component is NOT the definer.
op.callee_defines_resource = false;
}
}
Expand All @@ -2125,7 +2129,9 @@ impl Resolver {
.unwrap_or(&op.import_field);
if rg.defines_resource(*to_comp, iface, rn) {
op.callee_defines_resource = true;
} else if rg.is_reexporter(*to_comp, iface, rn)
} else if rg
.resource_definer(iface, rn)
.is_some()
{
op.callee_defines_resource = false;
}
Expand Down Expand Up @@ -2324,7 +2330,7 @@ impl Resolver {
.unwrap_or(&op.import_field);
if rg.defines_resource(*to_comp, iface, rn) {
op.callee_defines_resource = true;
} else if rg.is_reexporter(*to_comp, iface, rn) {
} else if rg.resource_definer(iface, rn).is_some() {
op.callee_defines_resource = false;
}
}
Expand All @@ -2335,7 +2341,7 @@ impl Resolver {
.unwrap_or(&op.import_field);
if rg.defines_resource(*to_comp, iface, rn) {
op.callee_defines_resource = true;
} else if rg.is_reexporter(*to_comp, iface, rn) {
} else if rg.resource_definer(iface, rn).is_some() {
op.callee_defines_resource = false;
}
}
Expand Down
Loading