BUG: Use remove_orphans in compress_identical_objects#3310
Open
j-t-1 wants to merge 4 commits intopy-pdf:mainfrom
Open
BUG: Use remove_orphans in compress_identical_objects#3310j-t-1 wants to merge 4 commits intopy-pdf:mainfrom
j-t-1 wants to merge 4 commits intopy-pdf:mainfrom
Conversation
Issue py-pdf#3306: PdfWriter.compress_identical_objects ignored remove_orphans. Correct for this. Also deprecate_with_replacement remove_orphans to remove_unreferenced.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 53 53
Lines 9029 9033 +4
Branches 1674 1676 +2
=======================================
+ Hits 8732 8736 +4
Misses 177 177
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| remove_unreferenced: Remove unreferenced objects. | ||
|
|
||
| """ | ||
| deprecate_with_replacement( |
Collaborator
There was a problem hiding this comment.
This deprecation does not work and will always trigger - even without using the old parameter.
Contributor
Author
There was a problem hiding this comment.
rename_kwargs should be used instead?
Collaborator
There was a problem hiding this comment.
If this works with positional arguments as well, yes. Otherwise, we would have to think of another approach like setting a object() constant as default for the deprecated parameter to be able to identify it correctly.
stefan6419846
added
the
needs-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3306: PdfWriter.compress_identical_objects ignored remove_orphans. Correct for this. Also deprecate_with_replacement remove_orphans to remove_unreferenced.