MAINT: PEP8 further compliance (manual check) constants.py module#3750
Draft
alan-techdev wants to merge 2 commits intopy-pdf:mainfrom
Draft
MAINT: PEP8 further compliance (manual check) constants.py module#3750alan-techdev wants to merge 2 commits intopy-pdf:mainfrom
alan-techdev wants to merge 2 commits intopy-pdf:mainfrom
Conversation
… for constants.py module
…k for constants.py module
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3750 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 55 55
Lines 10228 10228
Branches 1877 1877
=======================================
Hits 9982 9982
Misses 141 141
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
Apr 30, 2026
Collaborator
stefan6419846
left a comment
There was a problem hiding this comment.
Could you please have a look at the failing tests?
Additionally, this unfortunately is wrong - pypdf.constants is a public module, thus - even if they are not part of the docs directly - they have to be considered public API. Renaming them thus requires a proper deprecation process.
Contributor
Author
|
Noted. I will try to address private module instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially fixes the Issue 3231 by focusing on none public API inside the pypdf/constants.py module.
public API for constants module
In regards to constants.py line 586 ( op = "/op") and 602 (ca = "/ca"); they are being left in order to avoid breaking the test cases (test_constants.py::test_slash_prefix) line 36 which state the below
The attribute is hardcoded so either we change the test case or ?
The reason is to keep PR into minium