MAINT: Use placeholder-based approach for logger_warning#3759
Open
iso-techdev wants to merge 2 commits intopy-pdf:mainfrom
Open
MAINT: Use placeholder-based approach for logger_warning#3759iso-techdev wants to merge 2 commits intopy-pdf:mainfrom
iso-techdev wants to merge 2 commits intopy-pdf:mainfrom
Conversation
Collaborator
|
Some tests still fail. Additionally, I will wait for #3746 to be possibly finished which already covers the same topic, but has been opened a few days ago already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first pr was done for logger_error.
Now this second pr is the same but for the logger_warning.