Skip to content

MAINT: Remove unused rules from tool.ruff.lint#3760

Open
j-t-1 wants to merge 2 commits intopy-pdf:mainfrom
j-t-1:ruff
Open

MAINT: Remove unused rules from tool.ruff.lint#3760
j-t-1 wants to merge 2 commits intopy-pdf:mainfrom
j-t-1:ruff

Conversation

@j-t-1
Copy link
Copy Markdown
Contributor

@j-t-1 j-t-1 commented May 6, 2026

No description provided.

@j-t-1
Copy link
Copy Markdown
Contributor Author

j-t-1 commented May 6, 2026

"B905", # zip()without an explicitstrict= parameter

I do not know why this can be ignored, since we have it in the codebase.

@stefan6419846
Copy link
Copy Markdown
Collaborator

It might only trigger with the proper target Python version.

@j-t-1
Copy link
Copy Markdown
Contributor Author

j-t-1 commented May 6, 2026

It might only trigger with the proper target Python version.

Yes, it is something like that; the Ruff tests are Python 3.14.

@stefan6419846
Copy link
Copy Markdown
Collaborator

This should not matter, as this is runtime version, not the target version.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (cbc0ef5) to head (fb44cb1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3760   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          55       55           
  Lines       10225    10225           
  Branches     1877     1877           
=======================================
  Hits         9979     9979           
  Misses        141      141           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Copy Markdown
Collaborator

Could you please check locally whether raising the target version does indeed report some of these to avoid doubts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants