Skip to content

Conversation

@mrbean-bremen
Copy link

@mrbean-bremen mrbean-bremen commented Feb 24, 2025

  • ubuntu-20.04 is no longer supported, ubuntu-latest is now 24.04
  • fix workflow syntax
  • fix ruff syntax

I had noticed that most of the tests fail because they can't find a runner (my PR was merged, thanks for that!).

@mrbean-bremen mrbean-bremen force-pushed the ubuntu-runner branch 2 times, most recently from 2754977 to 5eaaf8a Compare February 24, 2025 17:40
@mrbean-bremen mrbean-bremen marked this pull request as draft February 24, 2025 17:41
@mrbean-bremen
Copy link
Author

Actually as was wrong - this did not run because of the syntax. Though ubuntu-20.04 is indeed deprecated and will soon be removed, this was not the problem.
And now the tests are all failing...

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@6e25ce2). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage        ?   93.27%           
=======================================
  Files           ?        8           
  Lines           ?      223           
  Branches        ?       50           
=======================================
  Hits            ?      208           
  Misses          ?        7           
  Partials        ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrbean-bremen mrbean-bremen marked this pull request as ready for review February 24, 2025 18:13
@mrbean-bremen
Copy link
Author

mrbean-bremen commented Feb 24, 2025

Ok, this is ready for review now.
(in case you saw that: I had accidentally checked in a change in pyproject.toml, appearantly made automatically by ux - reverted now)

- ubuntu-20.04 is no longer supported,
  ubuntu-latest is now 24.04
- fix workflow syntax
- fix ruff syntax
@kislyuk
Copy link
Member

kislyuk commented Feb 24, 2025

LGTM, thanks!

@kislyuk kislyuk merged commit 2c152d4 into pyauth:main Feb 24, 2025
20 checks passed
@mrbean-bremen mrbean-bremen deleted the ubuntu-runner branch February 24, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants