Pass SLO annotations to ConfigMap #1497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metalmatze this would be helpful for our system since we are using cortex and require some annotations on the dedicated |
Member
|
Thank you for sending this! There are some tests that need to be fixed. You can always try locally before pushing your changes by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in ConfigMap mode (
--config-map-mode) we need to pass annotations to the created ConfigMaps.Just like with Labels, the easiest way is to pass the annotations down to the ConfigMap as well.
This PR introduces that: To just pass the annotation map down to the created configmap in the slo controller.
Note: I didn't add a test for this. If you prefer to have a test, just let me know 😃