This repository was archived by the owner on Aug 5, 2025. It is now read-only.
Open
Conversation
kwen2501
reviewed
Apr 22, 2024
Contributor
kwen2501
left a comment
kwen2501
left a comment
There was a problem hiding this comment.
Thanks for enabling the CI. Left one comment.
| loss_fn=loss_fn, | ||
| ) | ||
| schedule.step_microbatches(microbatches) | ||
| schedule.step_microbatches(microbatches, target_mbs=target_mbs) |
Contributor
There was a problem hiding this comment.
Should we feed target to every rank?
Member
Author
There was a problem hiding this comment.
we don't have to, but if we do that is also allright too since if it is not the last stage then it wont calculate the loss using the target_mbs.
Contributor
There was a problem hiding this comment.
I'd rather not rely on assumptions :)
We should test the real case (strictly speaking even microbatches should not be fed to every rank).
| torch.randn_like(microbatch) for _ in range(num_microbatches) | ||
| ] | ||
| schedule.step_microbatches(microbatches) | ||
| schedule.step_microbatches(microbatches, target_mbs=target_mbs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):