Llama distributed example#3831
Open
apbose wants to merge 3 commits intoabose/trt_llm_installation_distfrom
Open
Llama distributed example#3831apbose wants to merge 3 commits intoabose/trt_llm_installation_distfrom
apbose wants to merge 3 commits intoabose/trt_llm_installation_distfrom
Conversation
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py 2025-09-22 06:34:48.499754+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py 2025-09-22 06:35:25.106098+00:00
@@ -863,6 +863,6 @@
return False
def is_thor() -> bool:
if torch.cuda.get_device_capability() in [(11, 0)]:
- return True
\ No newline at end of file
+ return True6e99bbc to
7134053
Compare
68dcaef to
ca70a9d
Compare
ca70a9d to
5700249
Compare
5700249 to
b59abbf
Compare
3f1fa7e to
54948d9
Compare
b59abbf to
480fb0a
Compare
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/distributed/utils.py 2025-09-25 20:01:17.061900+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/distributed/utils.py 2025-09-25 20:01:51.633567+00:00
@@ -100,11 +100,10 @@
return True
except Exception as e:
logger.warning(f"Failed to detect CUDA version: {e}")
return False
-
return True
def _cache_root() -> Path:2bbc423 to
5beefc0
Compare
5beefc0 to
809c7ee
Compare
480fb0a to
f00d349
Compare
bb6ec7a to
dd88017
Compare
809c7ee to
5fb74da
Compare
dd88017 to
3e3b54c
Compare
bd02455 to
38224c5
Compare
3e3b54c to
7c930fe
Compare
f07b5cb to
4118355
Compare
f57fac9 to
30dcc4c
Compare
83e528f to
402d703
Compare
narendasan
reviewed
Dec 1, 2025
| @fn_supports_debugger # type: ignore[misc] | ||
| def compile_module( | ||
| gm: torch.fx.GraphModule, | ||
| sample_arg_inputs: Sequence[Input], |
Collaborator
There was a problem hiding this comment.
Why is arg_inputs being deleted?
Collaborator
Author
There was a problem hiding this comment.
looked like the arg_inputs was not being used in the compile_module, hence I just removed it
402d703 to
802d17a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses