Fix portfolio mode by adding secAccNo parameter to compactPortfolio

[maximilian-sh]

Fixes #246

The Trade Republic API now requires secAccNo in the compactPortfolio subscription. Without it the API returns an empty portfolio silently.

Changes

• Cache securitiesAccountNumber from settings() response into self._sec_acc_no
• Pass secAccNo in compact_portfolio(), fetching it lazily if not yet available
• Raise a clear error if the account number can't be retrieved

Testing

• Confirmed v0.4.6 without fix returns empty portfolio
• Confirmed this branch returns all positions correctly

[ExploracuriousAlex]

I would make this private

[maximilian-sh]

Done, renamed to _secAccNo.

[ExploracuriousAlex]

Are all these locations still relevant to try?

In my case the securities account number is stored in settings_data["securitiesAccountNumber"]

[maximilian-sh]

Good point — simplified to only use settings_data["securitiesAccountNumber"]. The other fallbacks were speculative. Same field works for me as well.

[maximilian-sh]

Looked at the code again and reworked it a bit — moved _sec_acc_no to an instance attribute in __init__ instead of class level, dropped the unused compact_portfolio_by_type, and cleaned up the variable names. Logic is the same. Also rebased on master. Hope this can get merged.

[Gheop]

Confirming this fix works on a FR account holding only savings-plan ETF and equity positions (the kind of account where master consistently returns an empty positions array). With secAccNo added to the compactPortfolio payload, all positions come back correctly with instrumentId, netSize and averageBuyIn. No regressions noticed on settings() or accountPairs along the way.

The change is minimal and the lazy fetch via settings() keeps the existing call sites unchanged. Would be great to see this merged.

test

[RealCLanger]

While I don't see the issue on my account, I guess it helps some users, so merging this. I could obviously only verify that it still works on my account.