Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #245 +/- ##
=======================================
Coverage 76.67% 76.67%
=======================================
Files 38 38
Lines 5873 5873
=======================================
Hits 4503 4503
Misses 1370 1370 ☔ View full report in Codecov by Sentry. |
Author
|
CI is failing but I can't reproduce locally; the tests passed and black claimed all |
Member
HI Frank, thanks for adding the qiskit 1.0 support and making the PR. I will look into the failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates code and examples to work with Qiskit 1.0.
Why
Qiskit 1.0 brings some stability guarantees and performance improvements. Most new users will use Qiskit 1.0 and will expect this project to be compatibile with it.
How
Mostly find/replace of import paths. Also replacing
executewithbackend.run.See Qiskit 1.0 feature changes for more information.
Remarks
I re-ran the example notebooks that used Qiskit, with the exception of
examples/Full_loop_single_qubit.ipynbwhich I could not get working (see #244). Since it's not caused by the Qiskit upgrade, I think fixing it is out of scope of this PR. Please advise on how you'd like to handle it.View de1cde6 to see only the code changes to examples without the new cell outputs.
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the
- [x]prefixblackandflake8have been used to ensure styling guidelines are metnumpydocstyle