Added 'silent' and enhance documentation #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverqx
approved these changes
Dec 10, 2021
Author
|
@qmacro Just doing some cleanup/followup on my PRs and came across this. Looks to still be valid. Would you be willing to merge this in pls? |
qmacro
approved these changes
Nov 19, 2024
Owner
qmacro
left a comment
qmacro
left a comment
There was a problem hiding this comment.
LGTM - sorry it took so long! Mea culpa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree with @ silverqx that there's an empty response that appears to be unnecessary and confirmed on my system using zsh that the --silent option fixes the empty response.
also I had a small challenge getting it to work out of the box so just added some documentation to help the next person.