Draft
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for CMCD v2 parameters, specifically EventTarget and ReportingTargets. It includes a new EventTarget class, updates DashConstants and DashParser to recognize these new elements, and modifies CMCDParameters to parse them from the manifest. Additionally, CmcdPropertyMap and CmcdConfigAccessor have been updated to correctly prioritize and retrieve CMCD v2 target-specific properties from both manifest and player settings. A new function getEventTargetsFromCmcdParameters has been added to CmcdModel to expose these targets.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…nto cmcdv2/cmcd-parameters
…v2/cmcd-parameters
…v2/cmcd-parameters
…v2/cmcd-parameters
…v2/cmcd-parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request introduces comprehensive support for CMCD v2 Parameters, focusing on enabling manifest-driven configuration of reporting targets. It adds new data structures and parsing logic to interpret CMCD v2 elements within DASH manifests.
Highlights
ReportingTargetsandEventTargetelements in DASH manifests, allowing CMCD reporting configurations to be defined directly within the manifest.EventTargetClass: A dedicatedEventTargetclass is added to encapsulate the properties of each CMCD reporting destination, including URL, mode, keys, and events.