Skip to content

Feature/cmcdv2 update#162

Merged
cotid-qualabs merged 10 commits intofeature/cmcdv2from
feature/cmcdv2-update
Feb 10, 2026
Merged

Feature/cmcdv2 update#162
cotid-qualabs merged 10 commits intofeature/cmcdv2from
feature/cmcdv2-update

Conversation

@littlespex
Copy link

No description provided.

@gemini-code-assist
Copy link

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@littlespex littlespex marked this pull request as ready for review February 10, 2026 00:38
@littlespex
Copy link
Author

@nicolaslevy @cotid-qualabs These changes are ready to merge, but I noticed something when reviewing the CMCD event reports: When no events or keys are provided, the current code treats that as "All keys/events enabled". We moved away from this approach in CML for 2 reasons:

  1. There are so many new keys and events in v2, so defaulting to everything seems like too much.
  2. It is easier to reason about the code base when an empty array simply means "nothing", instead of it being a special case that actually means "everything".

Was this functionality added in the initial v2 changes, or was this how it worked in previous versions of dash.js with CMCD v1 support?

@cotid-qualabs
Copy link

@littlespex We implemented that behavior in the first approach we took for CMCDv2, but it seems we missed updating it after it became deprecated. We will update the behavior on this branch if that’s okay

@cotid-qualabs
Copy link

Just to be aligned, the updated behavior is:

  • If no events are defined (or the array is empty), no reports are sent.
  • If no keys are defined (or the array is empty), only mandatory keys are sent.

Combinations:

  • No events + defined keys → no report is sent.
  • Events + undefined keys → only mandatory keys are sent.
  • No events + no keys → no report is sent.
  • Events + keys → a report is sent.

Is this correct?

@littlespex
Copy link
Author

That is the correct behavior.

@cotid-qualabs cotid-qualabs merged commit 72787f9 into feature/cmcdv2 Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants