Open
Conversation
N1Knight
requested changes
Nov 28, 2024
N1Knight
reviewed
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Overlays
Summary
This PR implements Overlay functionality, enabling the management and rendering of Overlay events within the player. The following changes were introduced:
Assumptions
Unit Tests
The following unit tests were added to ensure proper functionality:
configureVideoElementForOverlaysetupOverlayEventsEach test validates that the system processes the corresponding overlay event type correctly without exceptions or unexpected behavior. Example for extend mode:
Test cases
Assets used to test the different cases: