fix: use logger.exception for engine init failure to capture traceback#25
Open
kenyonxu wants to merge 1 commit into
Open
fix: use logger.exception for engine init failure to capture traceback#25kenyonxu wants to merge 1 commit into
kenyonxu wants to merge 1 commit into
Conversation
logger.exception() automatically includes the full traceback via sys.exc_info(), enabling root-cause diagnosis when engine init fails. Previously logger.warning only printed the exception message, making debugging Hermes Agent permanent-busy issues much harder.
varun369
added a commit
that referenced
this pull request
May 18, 2026
…k (PR #25) When engine initialization fails in the unified daemon's lifespan(), the previous code used logger.warning(..., exc) which only prints the exception message — not the full traceback. This makes root-cause diagnosis very difficult. Replace with logger.exception() which automatically includes the full traceback via sys.exc_info(). Author: kenyonxu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When engine initialization fails in the unified daemon's
lifespan(), the current code useslogger.warning("Engine init failed: %s", exc)which only prints the exception message — not the full traceback. This makes root-cause diagnosis very difficult, especially for issues where the error message alone is insufficient to trace the failure path.Fix
Replace
logger.warning("Engine init failed: %s", exc)withlogger.exception("Engine init failed"). Thelogger.exception()method automatically includes the full traceback viasys.exc_info(), providing complete diagnostic information in the log when engine init fails.