Support logo: false to disable sidebar/navbar logos with _brand.yml
#13922
+402
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema and code fix to allow explicitly disabling sidebar and navbar logo when `_brand.yml` defines one. Includes smoke test.
- Move theme configuration from top-level to format.html.theme with proper base theme [cosmo/darkly, brand] pattern - Add test for disabling both navbar and sidebar logos together
- add a navbar test for books too - test for disabling logo in sidebar in books project - add a test about disabling logo in sidebar and navbar with brand theme in books
- Add images and optimize their size using oxipng - add check in the second page for no logos - by default, sidebar will have a logo if a brand logo is defined
Skip logo processing when sidebar.logo is explicitly false to prevent config mutation that caused brand logos to appear on subsequent pages during quarto preview.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
_brand.ymlwith logo definitions, there was no way to disable the logo in specific navigation elements without removing it from the brand file.Now you can explicitly opt out:
Also works in book projects with
book.sidebar.logo: falseandbook.navbar.logo: false.Fixes #13910