Skip to content

Remove OS-specific netty-tcnative by eliminating netty-example dependency #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Remove OS-specific netty-tcnative by eliminating netty-example dependency #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6c77a7b
Replace netty-example with targeted Netty deps to eliminate OS-specif…
Copilot Apr 27, 2026
eafea49
Introduce netty.version property and remove os-maven-plugin extension
Copilot Apr 28, 2026
1a6b8cf
Merge branch 'master' into copilot/check-os-specific-dependency
chrjohn May 5, 2026
20da1d2
Re-add netty.version property to pom.xml
chrjohn May 5, 2026
206ae74
Update Netty to 4.2.13.Final and sync SocksServerHandler with upstream
Copilot May 5, 2026
463102b
Initial plan
Copilot May 5, 2026
36312f1
fix: use netty-example with netty-tcnative exclusion instead of copyi…
Copilot May 5, 2026
47c1720
Merge pull request #1212 from quickfix-j/copilot/update-maven-exclusion
chrjohn May 5, 2026
5f74bb5
Merge branch 'master' into copilot/check-os-specific-dependency
chrjohn May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,10 @@
<orchestra.file>OrchestraFIXLatest.xml</orchestra.file>
<org.quickfixj.orchestra.tools.version>1.0.3</org.quickfixj.orchestra.tools.version>
<jaxen.version>2.0.1</jaxen.version>
<jmh.version>1.37</jmh.version>
<jcstress.version>0.16</jcstress.version>
<hsqldb.version>1.8.0.10</hsqldb.version>
<jmh.version>1.37</jmh.version>
<jcstress.version>0.16</jcstress.version>
<hsqldb.version>1.8.0.10</hsqldb.version>
<netty.version>4.2.13.Final</netty.version>
<class-pruner-plugin.version>3.0.1</class-pruner-plugin.version>
</properties>

Expand Down
16 changes: 7 additions & 9 deletions quickfixj-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,14 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-example</artifactId>
<version>4.2.12.Final</version>
<version>${netty.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.burningwave</groupId>
Expand Down Expand Up @@ -231,14 +237,6 @@
</plugin>
</plugins>

<extensions>
<!-- required by Netty cross-platform build -->
<extension>
<groupId>kr.motd.maven</groupId>
<artifactId>os-maven-plugin</artifactId>
<version>1.7.1</version>
</extension>
</extensions>
</build>

<reporting>
Expand Down
Loading