Push on main #234
codeql
on: dynamic
Matrix: analyze
Annotations
13 warnings
|
unneeded `return` statement:
src/query/term_query/term_weight.rs#L52
warning: unneeded `return` statement
--> src/query/term_query/term_weight.rs:52:17
|
52 | return Err(does_not_match(doc));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
52 - return Err(does_not_match(doc));
52 + Err(does_not_match(doc))
|
|
|
large size difference between variants:
src/query/term_query/term_weight.rs#L20
warning: large size difference between variants
--> src/query/term_query/term_weight.rs:20:1
|
20 | / enum TermOrEmptyOrAllScorer {
21 | | TermScorer(TermScorer),
| | ---------------------- the largest variant contains at least 1968 bytes
22 | | Empty,
23 | | AllMatch(AllScorer),
| | ------------------- the second-largest variant contains at least 8 bytes
24 | | }
| |_^ the entire enum is at least 1968 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
21 - TermScorer(TermScorer),
21 + TermScorer(Box<TermScorer>),
|
|
|
unused import: `BitSetDocSet`:
src/query/range_query/range_query.rs#L272
warning: unused import: `BitSetDocSet`
--> src/query/range_query/range_query.rs:272:20
|
272 | AllScorer, BitSetDocSet, ConstScorer, EmptyScorer, EnableScoring, Query, QueryParser,
| ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
|
|
call to unsafe function `std::intrinsics::transmute` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L95
warning[E0133]: call to unsafe function `std::intrinsics::transmute` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:95:49
|
95 | 255 - std::arch::x86_64::_mm256_movemask_ps(std::mem::transmute::<DataType, __m256>(inside))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
--> bitpacker/src/filter_vec/avx2.rs:91:1
|
91 | unsafe fn compute_filter_bitset(val: __m256i, range: std::ops::RangeInclusive<__m256i>) -> u8 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
call to unsafe function `std::ptr::mut_ptr::<impl *mut T>::offset_from` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L79
warning[E0133]: call to unsafe function `std::ptr::mut_ptr::<impl *mut T>::offset_from` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:79:5
|
79 | output_tail.offset_from(output) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `std::ptr::const_ptr::<impl *const T>::offset` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L77
warning[E0133]: call to unsafe function `std::ptr::const_ptr::<impl *const T>::offset` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:77:17
|
77 | input = input.offset(1);
| ^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `std::ptr::mut_ptr::<impl *mut T>::offset` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L75
warning[E0133]: call to unsafe function `std::ptr::mut_ptr::<impl *mut T>::offset` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:75:23
|
75 | output_tail = output_tail.offset(added_len as isize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `std::arch::x86_64::_mm256_storeu_si256` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L74
warning[E0133]: call to unsafe function `std::arch::x86_64::_mm256_storeu_si256` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:74:9
|
74 | store_unaligned(output_tail as *mut __m256i, filtered_doc_ids);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `filter_vec::avx2::compact` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L73
warning[E0133]: call to unsafe function `filter_vec::avx2::compact` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:73:32
|
73 | let filtered_doc_ids = compact(ids, keeper_bitset);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `filter_vec::avx2::compute_filter_bitset` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L71
warning[E0133]: call to unsafe function `filter_vec::avx2::compute_filter_bitset` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:71:29
|
71 | let keeper_bitset = compute_filter_bitset(word, range_simd.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `filter_vec::avx2::u32_to_i32_avx2` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L70
warning[E0133]: call to unsafe function `filter_vec::avx2::u32_to_i32_avx2` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:70:20
|
70 | let word = u32_to_i32_avx2(word);
| ^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
|
|
call to unsafe function `std::arch::x86_64::_mm256_lddqu_si256` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L69
warning[E0133]: call to unsafe function `std::arch::x86_64::_mm256_lddqu_si256` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:69:20
|
69 | let word = load_unaligned(input);
| ^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
--> bitpacker/src/filter_vec/avx2.rs:48:1
|
48 | / unsafe fn filter_vec_avx2_aux(
49 | | mut input: *const __m256i,
50 | | range: RangeInclusive<i32>,
51 | | output: *mut u32,
52 | | offset: u32,
53 | | num_words: usize,
54 | | ) -> usize {
| |__________^
|
|
call to function `std::arch::x86_64::_mm256_xor_si256` with `#[target_feature]` is unsafe and requires unsafe block:
bitpacker/src/filter_vec/avx2.rs#L22
warning[E0133]: call to function `std::arch::x86_64::_mm256_xor_si256` with `#[target_feature]` is unsafe and requires unsafe block
--> bitpacker/src/filter_vec/avx2.rs:22:5
|
22 | op_xor(vals_u32x8s, HIGHEST_BIT_MASK)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to function with `#[target_feature]`
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
= help: in order for the call to be safe, the context requires the following additional target feature: avx2
note: an unsafe function restricts its caller, but its body is safe by default
--> bitpacker/src/filter_vec/avx2.rs:20:1
|
20 | unsafe fn u32_to_i32_avx2(vals_u32x8s: DataType) -> DataType {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unsafe_op_in_unsafe_fn)]` (part of `#[warn(rust_2024_compatibility)]`) on by default
|