Skip to content

Term and IndexingTerm cleanup #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Term and IndexingTerm cleanup #2750

wants to merge 2 commits into from
+144 −149

Conversation

@PSeitz
Copy link
Collaborator

@PSeitz PSeitz commented Nov 27, 2025 •
edited
Loading

Replace serialized field with proper Field in Term.
mark Term::serialized_term and Term::wrap as deprecated
add Serialize Deserialize to Term

Remove unused type tag in IndexingTerm (saves 1 byte per term in the termmap)
remove generic in Term and use derives instead of manual impls

fix: use IndexingTerm in postings_writer.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fulmicoton fulmicoton Awaiting requested review from fulmicoton

@fulmicoton-dd fulmicoton-dd Awaiting requested review from fulmicoton-dd

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PSeitz @PSeitz-dd