Game #276
Game #276
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 282 out of 372 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/vite/src/features/notifications-provider.tsx:1
- The
notifyfunction's dependency array is empty but it uses thedismissfunction internally. Sincedismissis no longer memoized, this could lead to stale closures or the dependency should includedismiss.
import { isNot } from 'fmrs';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const dismiss = (notification: WithKey<Notification>): void => { | ||
| setNotifications(filter(isNot<WithKey<Notification>>(notification))); | ||
| if (typeof notification.onDismiss === 'function') { | ||
| notification.onDismiss(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
The dismiss function is no longer wrapped in useEffectEvent, which means it will be recreated on every render. This could cause unnecessary re-renders in child components that depend on this function.
dosubot
bot
added
size:XXL
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 282 out of 431 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 282 out of 455 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 282 out of 456 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
No description provided.