Skip to content

fix(report): defer slash command interaction to prevent timeout #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Matsukami7 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

fix(report): defer slash command interaction to prevent timeout #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
12 changes: 8 additions & 4 deletions report/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,10 @@ async def do_report(
report_type = "emergency" if emergency else "regular"
logger.debug(f"Processing {report_type} report from {message.author.name} ({message.author.id})")

# Acknowledge the interaction immediately to avoid Discord's 3-second timeout
if interaction is not None and not interaction.response.is_done():
await interaction.response.defer(ephemeral=True)

# Pre-emptively delete the message for privacy reasons
if interaction is None:
logger.debug("Deleting original report message for privacy")
Expand Down Expand Up @@ -350,9 +354,9 @@ async def do_report(
report_reply = self.make_reporter_reply(channel.guild, channel, report_body, emergency)

# Send interaction response if this is a slash command
if interaction is not None and not interaction.response.is_done():
logger.debug("Sending confirmation via interaction response")
await interaction.response.send_message(embed=report_reply, ephemeral=True)
if interaction is not None:
logger.debug("Sending confirmation via interaction followup")
await interaction.followup.send(embed=report_reply, ephemeral=True)

# Else send a DM if DM confirmations are enabled
elif await self.config.guild(channel.guild).confirmations():
Expand Down Expand Up @@ -409,7 +413,7 @@ async def notify_truncation(
f"⚠️ Your report was truncated from {original_length} to {truncated_length} characters "
f"due to Discord's limits. The report was still sent successfully."
)
if interaction is not None and not interaction.response.is_done():
if interaction is not None:
await interaction.followup.send(truncation_msg, ephemeral=True)
logger.debug("Truncation notification sent via interaction followup message")
else:
Expand Down
Loading