feat: Implement AccountStore persistence and wire CLI CRUD (#7) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add disk-backed AccountStore using JSON and platform config paths for CRUD operations on account metadata. Update CLI commands (add/list/remove) to use AccountStore and delete secrets on removal. Changes: - Add AccountStore with JSON persistence under ~/.config/sigilforge/ - Implement add_account, get_account, list_accounts, remove_account - Update CLI handlers to use AccountStore for all operations - Add error handling with non-zero exit for missing accounts - Add comprehensive integration tests in account_lifecycle.rs - Add directories and tempfile dependencies The AccountStore provides platform-specific storage using the directories crate, with proper error handling and thread safety via Arc<RwLock>. CLI now reflects persisted accounts and provides user feedback on storage location. Tests cover happy paths, error cases, persistence, and edge cases like duplicate accounts, filtering, and service ID normalization. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
sigilforge-core/src/account_store.rs- New AccountStore implementationsigilforge-cli/src/main.rs- CLI handlers now use persistent storagesigilforge-core/tests/account_lifecycle.rs- 17 integration testsTest plan
Closes #7
🤖 Generated with Claude Code