feat: Implement OAuth flows + DefaultTokenManager (#9) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements GitHub Issue #8, adding OS keyring-backed secret storage with graceful fallback to MemoryStore when the keyring is unavailable. Changes: - Refactored store.rs into modular structure (store/mod.rs, store/memory.rs) - Implemented KeyringStore behind keyring-store feature flag - Added create_store() helper that selects backend based on feature availability - KeyringStore uses platform native keyrings (macOS Keychain, Linux Secret Service, Windows Credential Manager) - Graceful fallback to MemoryStore with clear warning logs when keyring unavailable - Added comprehensive tests including platform-aware keyring tests - Tests handle headless environments where keyring daemon may not be running Implementation Details: - KeyringStore implements SecretStore trait for OS keyring operations - create_store() attempts KeyringStore first if prefer_keyring=true - Falls back to MemoryStore if keyring backend unavailable - Includes appropriate logging at info/warn/debug levels - list_keys() operation not supported by keyring backend (limitation of platform APIs) Testing: - All 31 tests pass including keyring-specific tests - Tests gracefully skip or adapt when keyring daemon unavailable - Documented platform requirements and limitations Fixes #8 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
sigilforge-core/src/oauth/- PKCE and device code implementationssigilforge-core/src/provider.rs- Provider registrysigilforge-core/src/token_manager.rs- DefaultTokenManagersigilforge-core/tests/token_refresh.rs- 11 integration testsTest plan
--features oauthCloses #9
🤖 Generated with Claude Code