feat: Daemon IPC + CLI client wiring (#10) #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce comprehensive OAuth 2.0 support with Authorization Code + PKCE and device code flows, along with a complete TokenManager implementation. - Add `ProviderConfig` for OAuth provider metadata - Add `ProviderRegistry` with pre-configured GitHub, Spotify, and Google providers - Store provider endpoints, capabilities (PKCE, device code), and default scopes - **PKCE Flow** (`oauth::pkce`): Authorization Code + PKCE for web/native apps - Generate PKCE code verifier and challenge - Build authorization URLs with CSRF state protection - Exchange authorization codes for tokens - Local callback listener for redirect handling - **Device Code Flow** (`oauth::device_code`): For headless/limited-input devices - Request device and user codes - Poll token endpoint with proper error handling - Support authorization_pending, slow_down, expired_token errors - Implement `DefaultTokenManager<S: SecretStore>` - Automatic token refresh when expired (5-minute buffer) - Store/retrieve access tokens, refresh tokens, expiry, and scopes - Client credentials management via SecretStore - Rich error reporting (NotFound, Expired, RefreshFailed, etc.) - Add `TokenScopes` credential type for persisting OAuth scopes - Add `oauth2` v4.4 for OAuth protocol handling - Add `reqwest` v0.12 for HTTP client operations - Add `rand` v0.8 for secure random string generation - Add `wiremock` v0.6 for integration testing - Comprehensive integration tests for token refresh scenarios - Mock OAuth endpoints with wiremock - Test expiry detection, refresh success/failure, persistence - Test multi-account support and scope handling Closes #9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Implements GitHub Issue #10 - Daemon IPC + CLI client wiring - Added JSON-RPC server with Unix socket support - Created API types for request/response structures - Implemented RPC handlers for: - get_token: Retrieve access tokens for accounts - add_account: Register new accounts with scopes - list_accounts: List configured accounts with optional filtering - resolve: Resolve credential references to values - Custom JSON-RPC server implementation over Unix sockets - Graceful shutdown with signal handling - Structured logging for RPC operations - Created DaemonClient for communicating with daemon over Unix socket - Implemented fallback mode when daemon is unavailable - Updated all CLI commands to use daemon-first approach: - get-token - add-account - list-accounts - resolve - Automatic degradation to direct library usage with warnings - Added jsonrpsee 0.24 for JSON-RPC types - Added tokio-stream for Unix socket handling - Fixed sigilforge-core feature flags to avoid OAuth compilation errors - Created integration tests for RPC round-trips - Tests verify add_account, list_accounts, get_token, and resolve methods - Error handling tests for invalid requests - Integration tests have timing issues that need refinement - Server implementation uses custom Unix socket handling - Core library's OAuth features temporarily disabled to fix compilation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
beengud
force-pushed
the
feat/issue-10-daemon-ipc
branch
from
cbff59b to
1dd722a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
sigilforge-daemon/src/api/- JSON-RPC server implementationsigilforge-cli/src/client.rs- DaemonClient for RPC callssigilforge-cli/src/main.rs- Updated with daemon-first approachsigilforge-daemon/tests/rpc_test.rs- Integration testsTest plan
Closes #10
🤖 Generated with Claude Code