[golangci-lint] Enable deprecated API warnings linter#4605
Merged
andrewsykim merged 1 commit intoray-project:masterfrom Apr 15, 2026
Merged
[golangci-lint] Enable deprecated API warnings linter#4605andrewsykim merged 1 commit intoray-project:masterfrom
andrewsykim merged 1 commit intoray-project:masterfrom
Conversation
mboersma
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
mboersma
changed the title
win5923
approved these changes
Mar 19, 2026
win5923
reviewed
Mar 19, 2026
Comment on lines
+102
to
+107
| # NewSimpleClientset is deprecated in favor of NewClientset, but | ||
| # NewClientset requires a complete SMD schema for field management | ||
| # which breaks Update-based tests. TODO: migrate once SMD schemas | ||
| # are properly generated for all kuberay types. | ||
| - linters: [staticcheck] | ||
| text: "SA1019:.*NewSimpleClientset" |
Member
There was a problem hiding this comment.
Could you open a issue to track this?
Contributor
Author
There was a problem hiding this comment.
@win5923 thanks for the review! I removed the outdated comments about SA1019 and opened an issue to track SMD schemas.
2 tasks
mboersma
force-pushed
the
linter-enable-SA1019
branch
from
3777e87 to
eb7cebf
Compare
4 tasks
Contributor
Author
win5923
approved these changes
Apr 11, 2026
Member
win5923
left a comment
win5923
left a comment
There was a problem hiding this comment.
LGTM! sorry for the delay, I was on vacation the past few weeks.
Contributor
Author
|
Thanks @win5923, no problem--I hope you had a great vacation. What's needed now to get this merged? Should I ask another maintainer for a review? |
Member
|
Yeah, I think Andrew or Rueian could help with a final review. |
Contributor
Author
|
ping @andrewsykim @rueian |
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
I didn't review this PR, but I think we can trust @win5923 's review
github-project-automation
bot
moved this from can be merged
to Done
in @Future-Outlier's kuberay project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
kuberay has had SA1019 disabled in the golangci-lint config, which led to some deprecated API calls remaining. This enables the linter in general, but carves out exceptions for kuberay's own deprecated fields.
Related issue number
Checks