feat(sdk): remove name from project create #1314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rsbh
changed the title
| ); | ||
| const slug = slugify(data.title, { lower: true, strict: true }); | ||
| const suffix = generateHashFromString(organization.id); | ||
| const name = `${slug}-${suffix}`; |
Contributor
There was a problem hiding this comment.
I think we should name the var slug instead of name.
Pull Request Test Coverage Report for Build 19925604353Details
💛 - Coveralls |
| if (error instanceof ConnectError && error.code === Code.AlreadyExists) { | ||
| setError('title', { | ||
| message: | ||
| 'A project with a similar title already exist. Please tweak the title and try again.' |
Contributor
There was a problem hiding this comment.
similar vs same?
I think same should be the copy. A Project with the same title already exists. or A Project with the title already exists. Thoughts?
Member
Author
There was a problem hiding this comment.
The slug is in lower case.
So Title and title will create same slug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the name field from the project creation form.
Changes
The name will be auto-generated from the title, and a hash from the org ID will be added as a suffix.
Due to this.
Technical Details
We are using the
djb2hashing algorithm to generate a hash from the string.The error capture has been moved from
onErrorto catch block TanStack/query#1784Test Plan