Skip to content

refactor: deprecate billing_id in checkout RPCs #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+40 −18
Open

refactor: deprecate billing_id in checkout RPCs #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d2868
chore: deprecate billing_id in checkout RPCs
whoAbhishekSah Nov 21, 2025
6f5110c
chore: deprecate org_id in GetCheckoutRequest
whoAbhishekSah Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions raystack/frontier/v1beta1/admin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,11 +1033,15 @@ message RemovePlatformUserResponse {}

message DelegatedCheckoutRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: billing_id will be inferred from org_id
// ID of the billing account to update the subscription for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];

// Subscription to create
CheckoutSubscriptionBody subscription_body = 10;
Expand Down
46 changes: 32 additions & 14 deletions raystack/frontier/v1beta1/frontier.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,11 +2275,15 @@ message CheckCreditEntitlementResponse {

message CreateCheckoutRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: billing_id will be inferred from org_id
// ID of the billing account to update the subscription for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];

string success_url = 3;
string cancel_url = 4;
Expand All @@ -2299,11 +2303,15 @@ message CreateCheckoutResponse {

message ListCheckoutsRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: billing_id will be inferred from org_id
// ID of the billing account to get the subscriptions for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];
}

message ListCheckoutsResponse {
Expand All @@ -2312,12 +2320,22 @@ message ListCheckoutsResponse {
}

message GetCheckoutRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// ID of the billing account to get the subscriptions for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
// DEPRECATED: org_id is not needed, checkout can be fetched by id alone
string org_id = 1 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
min_len: 3
}
];
// DEPRECATED: billing_id is not needed, checkout can be fetched by id alone
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];
// ID of the checkout to get
string id = 3 [(validate.rules).string.min_len = 1];
}
Expand Down
Loading