Skip to content

fixes #77 (navbar): add proper navigation links to all navbar items#179

Closed
sidharth-vijayan wants to merge 1 commit into
rdodiya:gssoc_developfrom
sidharth-vijayan:fix/navbar-navigation-links
Closed

fixes #77 (navbar): add proper navigation links to all navbar items#179
sidharth-vijayan wants to merge 1 commit into
rdodiya:gssoc_developfrom
sidharth-vijayan:fix/navbar-navigation-links

Conversation

@sidharth-vijayan
Copy link
Copy Markdown

Issue Link

Closes #77

Changes Made

  • Wrapped the Restroly logo and brand name in a React Router <Link> pointing to /
  • Added href="#features" anchor to the Features navbar item for smooth section scroll
  • Linked "Get Started Free" button to the registration page using <Link to="/register">
  • Linked "Login In" button to the login page using <Link to="/login">

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Code refactor (for discussed optimization)

Testing Performed

Frontend Testing (if applicable)

  • Component renders correctly
  • Responsive on mobile/tablet/desktop
  • No console errors
  • Test Cases:
    • Test case 1: Clicked logo from /pricing page → navigated to /
    • Test case 2: Clicked "Features" → scrolled to features section on homepage ✅
    • Test case 3: Clicked "Get Started Free" → navigated to registration page ✅
    • Test case 4: Clicked "Login In" → navigated to login page ✅

UI/UX Changes

  • Before: Logo and navbar items were non-interactive (no cursor change, no navigation)
  • After: All navbar items navigate correctly; logo has pointer cursor on hover

Functionality Demo (if applicable)

  • Steps to test: Run npm run dev in RestroHub-FrontEnd, navigate to any page other than home, then click each navbar item to verify correct routing.

Additional Notes

  • Used React Router v6 <Link> component for SPA navigation (no full page reload)
  • Features link uses hash-based anchor scroll (#features) as it targets a section on the homepage
  • No backend changes required

@sidharth-vijayan
Copy link
Copy Markdown
Author

Please review and let me know what you think.
Also kindly add a dificulty tag as well, for GSSoC.

@rdodiya
Copy link
Copy Markdown
Owner

rdodiya commented May 20, 2026

Hi @sidharth-vijayan ,
This changes are wrongly done. We don't have any pages, it's a SPA.
Closing this as this is done correctly under #91.

Please perform unit test on local.

Thanks for your contribution but we are not accepting this.

@rdodiya rdodiya closed this May 20, 2026
@sidharth-vijayan
Copy link
Copy Markdown
Author

Hi @sidharth-vijayan , This changes are wrongly done. We don't have any pages, it's a SPA. Closing this as this is done correctly under #91.

umm i never said anything about pages, said i fixed spa navigation

Please perform unit test on local.

i have tested it locally and everything was working smoothly, but aight. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Logo/brand name in navbar is not clickable — missing home link

2 participants