fixes #77 (navbar): add proper navigation links to all navbar items#179
Closed
sidharth-vijayan wants to merge 1 commit into
Closed
fixes #77 (navbar): add proper navigation links to all navbar items#179sidharth-vijayan wants to merge 1 commit into
sidharth-vijayan wants to merge 1 commit into
Conversation
Author
|
Please review and let me know what you think. |
Owner
|
Hi @sidharth-vijayan , Please perform unit test on local. Thanks for your contribution but we are not accepting this. |
Author
umm i never said anything about pages, said i fixed spa navigation
i have tested it locally and everything was working smoothly, but aight. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
Closes #77
Changes Made
<Link>pointing to/href="#features"anchor to the Features navbar item for smooth section scroll<Link to="/register"><Link to="/login">Type of Change
Testing Performed
Frontend Testing (if applicable)
/pricingpage → navigated to/✅UI/UX Changes
Functionality Demo (if applicable)
npm run devinRestroHub-FrontEnd, navigate to any page other than home, then click each navbar item to verify correct routing.Additional Notes
<Link>component for SPA navigation (no full page reload)#features) as it targets a section on the homepage