Skip to content

feat: retire deprecated api #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

feat: retire deprecated api #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3ecbbc
feat: retire deprecated api
aojunhao123 Feb 16, 2025
e5c0ae2
chore: update test code
aojunhao123 Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/CSSMotion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ export type CSSMotionConfig =
| boolean
| {
transitionSupport?: boolean;
/** @deprecated, no need this anymore since `rc-motion` only support latest react */
forwardRef?: boolean;
};

export type MotionName =
Expand Down
2 changes: 0 additions & 2 deletions tests/CSSMotion.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import RefCSSMotion, {
describe('CSSMotion', () => {
const CSSMotion = genCSSMotion({
transitionSupport: true,
forwardRef: false,
});

beforeEach(() => {
Expand Down Expand Up @@ -613,7 +612,6 @@ describe('CSSMotion', () => {
it('no transition', () => {
const NoCSSTransition = genCSSMotion({
transitionSupport: false,
forwardRef: false,
});

const { container } = render(
Expand Down
1 change: 0 additions & 1 deletion tests/CSSMotionList.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ describe('CSSMotionList', () => {
it('with motion support', () => {
const CSSMotion = genCSSMotion({
transitionSupport: true,
forwardRef: false,
});
const CSSMotionList = genCSSMotionList(true, CSSMotion);
testMotion(CSSMotionList, container => {
Expand Down
3 changes: 0 additions & 3 deletions tests/StrictMode.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@ import { fireEvent, render } from '@testing-library/react';
import classNames from 'classnames';
import React from 'react';
import { act } from 'react-dom/test-utils';
// import type { CSSMotionProps } from '../src/CSSMotion';
import { genCSSMotion, type CSSMotionRef } from '../src/CSSMotion';
// import RefCSSMotion, { genCSSMotion } from '../src/CSSMotion';
// import ReactDOM from 'react-dom';

describe('StrictMode', () => {
const CSSMotion = genCSSMotion({
Expand Down